admin/wordarr
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request 'fix(ui): center dialogs again after the global margin reset' (#6) from bugfix/center-dialogs into main
Build image / image (push) Successful in 52s
Details

Browse Source 
Reviewed-on: #6
This commit was merged in pull request #6.
This commit is contained in:
admin committed 2026-10-25 20:05:09 +01:00
2 parents 0d2ada3901 b85bdcf5aa
commit ebd981cc3c
2 files changed
+4 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

static/style.css
+2 -2
View File
@@ -104,8 +104,8 @@ td select { max-width: 340px; }
.score-none { color: var(--muted); } .score-none { color: var(--muted); }
.volume { width: 90px; } .volume { width: 90px; }
/* dialogs */ /* dialogs; margin: auto undoes the * reset, which pins them to the top left */
dialog { background: var(--panel); color: var(--text); border: 1px solid var(--border); border-radius: 8px; padding: 1.2rem; min-width: 340px; max-width: min(640px, 92vw); } dialog { margin: auto; background: var(--panel); color: var(--text); border: 1px solid var(--border); border-radius: 8px; padding: 1.2rem; min-width: 340px; max-width: min(640px, 92vw); }
dialog::backdrop { background: rgba(0,0,0,0.6); } dialog::backdrop { background: rgba(0,0,0,0.6); }
dialog label { display: flex; flex-direction: column; gap: 0.2rem; margin: 0.5rem 0; font-size: 0.9rem; color: var(--muted); flex: 1; } dialog label { display: flex; flex-direction: column; gap: 0.2rem; margin: 0.5rem 0; font-size: 0.9rem; color: var(--muted); flex: 1; }
.detail-head { display: flex; gap: 1rem; align-items: flex-start; margin-bottom: 0.5rem; } .detail-head { display: flex; gap: 1rem; align-items: flex-start; margin-bottom: 0.5rem; }
tests/test_ui_dialogs.py
+2
View File
@@ -97,6 +97,8 @@ def test_import_dialog_opens_and_closes(page):
page.click("[data-quick='0']") page.click("[data-quick='0']")
page.wait_for_selector("#quick-dialog[open]") page.wait_for_selector("#quick-dialog[open]")
assert page.locator("#quick-dialog").is_visible() assert page.locator("#quick-dialog").is_visible()
box = page.locator("#quick-dialog").bounding_box()
assert abs(box["x"] + box["width"] / 2 - 600) < 10 # centered in the viewport
# everything reachable, nothing cut off at the bottom # everything reachable, nothing cut off at the bottom
for sel in ("#quick-m-submit", "#quick-close"): for sel in ("#quick-m-submit", "#quick-close"):
box = page.locator(sel).bounding_box() box = page.locator(sel).bounding_box()